

0 / 2 embers
0 / 3000 xp
click for more info
Complete a lesson to start your streak
click for more info
Still calibrating
click for more info
Not enough gems
Cost: 6 gems
1: Security Checks
incomplete
2: CI Security
incomplete
3: Fix Security Issues
incomplete
4: Security Review
incomplete
This lesson's interactive features are locked, please to keep using them
We won't have to add a new step to our workflow because we already have a step running npm run lint. Unfortunately, the ESLint security plugin only returns warnings, this is because it can occasionally find false positives. But here at Notely we take our security warnings very seriously. We want our CI to fail if we see any security warnings.
Add the --max-warnings=0 flag to the lint step of your ci.yml. This will cause the command to return a 1 status code if there are any warnings. It should look something like this:
- name: Check linting
run: npm run lint -- --max-warnings=0
We want to be sure the security checks work, so the first time you push the new ci.yml file to your PR branch, we are intentionally making the check fail. Don't fix the errors in the Notely project code yet.
Paste the URL of your GitHub repo into the box and run the GitHub checks.